-
Notifications
You must be signed in to change notification settings - Fork 3
chore(devdeps): update dependency jsdom to v27.0.1 #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
View your CI Pipeline Execution ↗ for commit f4ebffa
☁️ Nx Cloud last updated this comment at |
bdedba9 to
ad994a6
Compare
ad994a6 to
391744e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The pull request updates jsdom from 27.0.0 to 27.0.1 and its transitive dependency parse5 from 7.3.0 to 8.0.0. The failing task is a Playwright end-to-end test suite located at e2e/davinci-suites/src/phone-number-field.test.ts.
Error Analysis:
Both failing tests follow the same pattern:
- Navigate to the application
- Attempt to register a new user by filling out a registration form
- Expect to see a heading with text "Registration Complete" after clicking Continue
- The element is never found, causing the test to fail with a timeout
- The afterEach hook then fails because the user was never successfully created, so the cleanup cannot proceed
The key insight is that jsdom is a JavaScript-based DOM implementation used for unit testing in Node.js environments (typically with test runners like Vitest or Jest). Playwright tests, however, run in actual browser contexts (Chromium, Firefox, or WebKit), not jsdom. The test file shows Playwright's browser automation APIs (page.goto, page.getByRole, etc.), which execute against real browsers.
The jsdom dependency in package.json is used by other parts of the monorepo for unit tests that need DOM APIs without a browser. The version bump from 27.0.0 to 27.0.1 would only impact those unit tests, not the Playwright E2E tests.
The test failure indicates that the registration workflow in the actual application is not completing successfully - the "Registration Complete" heading never appears. This could be due to:
- Backend API issues in the test environment
- Database connectivity problems
- Authentication service failures
- Test data conflicts (user already exists)
- Timing issues with the application's async operations
- Infrastructure/network issues in the CI environment
Since the jsdom upgrade cannot affect Playwright tests that run in real browsers, and the tests are failing due to application behavior (missing UI elements), this is classified as an environment_state failure. The dependency change is coincidental to the test failures.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
391744e to
f4ebffa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (19.05%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 19.05% 19.05%
=======================================
Files 138 138
Lines 27477 27477
Branches 975 975
=======================================
Hits 5237 5237
Misses 22240 22240 🚀 New features to boost your workflow:
|
@forgerock/davinci-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 1acd371 to https://ForgeRock.github.io/ping-javascript-sdk/pr-448/1acd3715d26353af4b3d796e9f56a774d5893ddc branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.0 KB, -100.0%) 📊 Minor Changes📈 @forgerock/journey-client - 82.0 KB (+0.0 KB) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
This PR contains the following updates:
27.0.0->27.0.1Release Notes
jsdom/jsdom (jsdom)
v27.0.1Compare Source
class=""attribute changes is only possible with a new version of jsdom. (asamuzaK)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.